Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons, Steve Markgraf.
Patch set 6:Code-Review +1
View Change
1 comment:
Patchset:
Patch Set #6:
Hi, Great work. […]
I think these both are good ideas. It would be great to be consistent with existing naming pattern of programmers and programmer parameters. We do have some ongoing work to centralize programmer parameters parsing logic, and having same names / data types when it makes sense helps a lot.
As for programmer name, being consistent with the existing names makes it easier for the users.
Otherwise I don't have much else. Steve, thanks heaps for your great work! We are almost there! :)
To view, visit change 71801. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icad3eb7764f28feaea51bda3a7893da724c86d06
Gerrit-Change-Number: 71801
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Markgraf <steve@steve-m.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Steve Markgraf <steve@steve-m.de>
Gerrit-Comment-Date: Tue, 24 Jan 2023 01:56:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Gerrit-MessageType: comment