Attention is currently required from: Dmitry Zhadinets, Peter Marheine.

View Change

3 comments:

• File cli_classic.c:

  • Patch Set #1, Line 1050: struct flashctx flashes[8] = {{0}};

    This array won't be needed after this patch, in the next commit it can be replaced with just one fla […]

    To elaborate what I was thinking about: I wanted to have some first reviews so that we decide that we go ahead with this. And then I will create separate commit to refactor the array and replace the array with one working context (because realistically only one context is used).

  • Patch Set #1, Line 1215: flashrom_flash_probe_v2

    Check the return value

    Done

• File cli_classic.c:

  • Patch Set #3, Line 1216: if (ret == 1) {

    A comment here is that: probing never returns 1, and v1 probing never returned 1 either. The root cause is that probe_flash returns -1 for both the case when no match found and when any error happens during probing :(

    I added this ret code handling because I think that it's reasonable for libflashrom client to check ret code.
    The situation that libflashrom never returns 1 despite of API documentation is more of internal issue, maybe we will fix it later. Meanwhile clients can check ret code according to documentation.

    I am also interested what do people think about it.

To view, visit change 87341. To unsubscribe, or for help writing mail filters, visit settings.