Attention is currently required from: Alexander Goncharov, Miklós Márton.
View Change
1 comment:
File ni845x_spi.c:
Patch Set #3, Line 635: data->io_voltage_in_mV = io_voltage_in_mV;
I've just dropped this line, because `io_voltage_in_mV` will be set in the `usb8452_spi_set_io_volta […]
I agree with dropping the line: there was no "default" initialisation of `io_voltage_in_mV` before, it was initialised inside `usb8452_spi_set_io_voltage()` and the approach stays the same.
To view, visit change 72160. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I45fcb8e20582cb0c532c4a9f0c78543a25f8d484
Gerrit-Change-Number: 72160
Gerrit-PatchSet: 4
Gerrit-Owner: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-Attention: Alexander Goncharov <chat@joursoir.net>
Gerrit-Comment-Date: Sat, 15 Jul 2023 10:11:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Miklós Márton <martonmiklosqdev@gmail.com>
Comment-In-Reply-To: Alexander Goncharov <chat@joursoir.net>
Gerrit-MessageType: comment