Attention is currently required from: Felix Singer, Thomas Heijligen.
Patch set 2:Code-Review +1
View Change
1 comment:
File meson.build:
Patch Set #2, Line 413: include_directories : include_directories('src/include'),
IIRC, you can avoid repeating the patch by using a variable, e.g. one on top:
include_dirs = include_directories('src/include')
and then use
include_directories : include_dirs,
everywhere. It even works literally in the `ich_descriptors_tool/meson.build`,
cf. CB:58305.
To view, visit change 58622. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iaddd6bbfa0624b166d422f665877f096983bf4cf
Gerrit-Change-Number: 58622
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Comment-Date: Tue, 26 Oct 2021 14:55:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment