Attention is currently required from: Angel Pons, Arthur Heymans.

Patch set 1:Code-Review -2

View Change

1 comment:

• Commit Message:

  • Patch Set #1, Line 8:

    
    This was missed because `uint32_t` is `unsigned int` in most cases.
    However, it is not the case for DJGPP 6.1.0 for some reason.
    

    this does not sit right with me. I believe the correct fix here is to simply correct the prototypes in chipdrivers.h which seem to be wrong:

    ```
    git grep -E '(s25fs_block_erase_d8|s25fl_block_erase)' chipdrivers.h
    chipdrivers.h:int s25fl_block_erase(struct flashctx *flash, unsigned int addr, unsigned int blocklen);
    chipdrivers.h:int s25fs_block_erase_d8(struct flashctx *flash, unsigned int addr, unsigned int blocklen);
    ```

    uint32_t seems to be the correct type.

To view, visit change 52473. To unsubscribe, or for help writing mail filters, visit settings.