Attention is currently required from: Alan Green, Nico Huber, Edward O'Callaghan, Anastasia Klimchuk, Samir Ibradžić.

View Change

6 comments:

• File ft2232_spi.c:

  • Patch Set #25, Line 317: if (!cmds->readcnt && ((cmds + 1)->writecnt || (cmds + 1)->readcnt)){

    > Checking if next command fits is a very good idea! I did as you proposed. […]

    Done

• File ft2232_spi.c:

  • Patch Set #29, Line 171: return 12 + cmd->writecnt + cmd->readcnt <= buffer_size;

    I just realized we could make the check more accurate, taking into account […]

    I think it is a cleaner solution and, theoretically, it could save some send_buf() calls.

  • Patch Set #29, Line 306:

    		/* Overflow check for buf
    		 *  12 : up to 12 CMD-Bytes are added below
    		 */
    

    I think we can drop the comment here, the function name should be self-explanatory.

    Done

  • Patch Set #29, Line 344:

    			((cmds + 1)->writecnt || (cmds + 1)->readcnt) &&
    			ft2232_spi_command_fits((cmds + 1), FTDI_HW_BUFFER_SIZE - i)) {
    

    Please indent either with 4 spaces or two tabs (relative to the `if`). […]

    Done

  • Patch Set #29, Line 352:

    			msg_perr("send_buf failed: %i\n", ret);
    			break;
    

    Needs braces.

    Doing too much python ;-)

  • Patch Set #29, Line 358:

    				msg_perr("get_buf failed: %i\n", ret);
    				break;
    

    Same here.

    Done

To view, visit change 40477. To unsubscribe, or for help writing mail filters, visit settings.