Attention is currently required from: Hsuan-ting Chen.

View Change

1 comment:

• File ichspi.c:

  • Patch Set #1, Line 1848: case CHIPSET_METEOR_LAKE:

    It was your previous CL that put MTL in that position

    For sure that is my CL which added MTL after ADL but there is no such restriction to maintain the order. You can move the macro at the end of the list.

    (https://review.coreboot.org/c/flashrom/+/62783) Could you share if (1) We could move it to the very end

    Please move MTL as the end so we can add LNL and PTL after MTL.

    (2) Will there be any other chipset name which will be moved to make the order makes sense?

    Looking at ur current logic, i felt the MTL is the first SOC where we would like to enable this support hence, moving MTL is okay and new Intel SOC can be added after MTL so, the suggested logic (by me) works w/o any maintenance burden.

To view, visit change 81357. To unsubscribe, or for help writing mail filters, visit settings.