This should be rebased on the SPI command set commit, and add and
use
another class. Looks very good otherwise.
Big problem is that this change "23259" depends on already verified "23258" and its' "FEATURE_ERASED_ZERO" . When I try rebasing it on top of "23262" (SPI command set) I get a -1 build error from Jenkins. I'm not sure what to do next... Also its' a bit unclear to me, what did you mean by "add and use another class" for this commit. Please could you clarify?
View Change
To view, visit change 23259. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8b2eb2feeef5c337d725d15ebf994a299897854
Gerrit-Change-Number: 23259
Gerrit-PatchSet: 8
Gerrit-Owner: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Kocialkowski <contact@paulk.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 08 Feb 2018 12:49:32 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No