Thanks for doing this, however I spotted a small issue with the Numonyx 512mbit part that should be addressed.

Patch set 5:Code-Review -1

View Change

2 comments:

• File flashchips.c:

  • Patch Set #5, Line 10628: 1E", /* ..1E = 1.8V, uniform 64KB/4KB blocks/sectors */

    This is not quite right - The suffix on 512mbit parts should be 1G for 1.8V, uniform sectors. For example: https://www.micron.com/products/nor-flash/serial-nor-flash/part-catalog/n25q512a11g1240e

  • Patch Set #5, Line 10631: 1E

    Not your fault, but this should be 1G.

To view, visit change 34491. To unsubscribe, or for help writing mail filters, visit settings.