Thanks for doing this, however I spotted a small issue with the Numonyx 512mbit part that should be addressed.
Patch set 5:Code-Review -1
View Change
2 comments:
File flashchips.c:
Patch Set #5, Line 10628: 1E", /* ..1E = 1.8V, uniform 64KB/4KB blocks/sectors */
This is not quite right - The suffix on 512mbit parts should be 1G for 1.8V, uniform sectors. For example: https://www.micron.com/products/nor-flash/serial-nor-flash/part-catalog/n25q512a11g1240e
Patch Set #5, Line 10631: 1E
Not your fault, but this should be 1G.
To view, visit change 34491. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I85630e4f6c0aa3b261f9871b7d363dad278b997e
Gerrit-Change-Number: 34491
Gerrit-PatchSet: 5
Gerrit-Owner: Jacob Creedon <jcreedon@google.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Jacob Creedon <jcreedon@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sat, 07 Sep 2019 22:27:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment