David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34491 )
Change subject: flashchips: Add missing N25Q/MT25Q 1.8v variants ......................................................................
Patch Set 5: Code-Review-1
(2 comments)
Thanks for doing this, however I spotted a small issue with the Numonyx 512mbit part that should be addressed.
https://review.coreboot.org/c/flashrom/+/34491/5/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/34491/5/flashchips.c@10628 PS5, Line 10628: 1E", /* ..1E = 1.8V, uniform 64KB/4KB blocks/sectors */ This is not quite right - The suffix on 512mbit parts should be 1G for 1.8V, uniform sectors. For example: https://www.micron.com/products/nor-flash/serial-nor-flash/part-catalog/n25q...
https://review.coreboot.org/c/flashrom/+/34491/5/flashchips.c@10631 PS5, Line 10631: 1E Not your fault, but this should be 1G.