Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen.
View Change
1 comment:
File buspirate_spi.c:
Patch Set #7, Line 709: (Open-Drain mode)
Is this always true? If both params are set, `pullup == true && hiz == true`, from you explanation I […]
pullups == true means open-drain mode + enable internal pull-ups
hi-z == true mean open drain mode
So yes, pullup or hiz means always: Open-Drain mode
To view, visit change 79299. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I6d9909b23782ef3fcb1428fd127dae0d6b211855
Gerrit-Change-Number: 79299
Gerrit-PatchSet: 7
Gerrit-Owner: David Reguera Garcia <dreg@rootkit.es>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: David Reguera Garcia <dreg@rootkit.es>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Thu, 07 Dec 2023 01:32:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment