View Change

1 comment:

• File ni845x_spi.c:

  • Patch Set #8, Line 63: /* Copied from dediprog.c */

    Actually it is copied from the pickit2 code:
    https://github.com/flashrom/flashrom/blob/master/pickit2_spi.c#L302

    I am under the impression too that these spi clock speed
    calculation functions shall be uniformized & placed to a common
    place.

    This is about voltage ;) but, yeah, `spispeed` suffers the same.

    What do you recommend? Should I create an another patchset
    which modifies dediprog, pickit and rebase this onto the top of
    that?

    That would be a good way, if you want to do it. A common place
    for `voltage` and `spispeed` parameter parsing would be great
    and much appreciated. Though, be warned, when it comes to
    `spipeed` there are a lot more drivers to touch.

To view, visit change 25683. To unsubscribe, or for help writing mail filters, visit settings.