Nico Huber posted comments on this change.

View Change

Patch set 2:

And I still won't review it this way. Single commits with a focused
commit message are easy to review. But this... I refuse to search a
commit message diff for the explanation of the changes.

If you find somebody else to review it, fine, I'll draw back my -2.

To view, visit change 21776. To unsubscribe, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: stable
Gerrit-MessageType: comment
Gerrit-Change-Id: I08a324ce1fd8afcc6f516ddfb6f09e05a67cdd17
Gerrit-Change-Number: 21776
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner@gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sun, 01 Oct 2017 08:45:58 +0000
Gerrit-HasComments: No