View Change

3 comments:

• File dummyflasher.c:

  • Patch Set #1, Line 175: data->emu_chip = EMULATE_NONE;

    This will trigger undefined behavior if `data` is null. Moreover, some compilers will happily optimize out the null check right below because of this. See the second example from here: https://lwn.net/Articles/575563

  • Patch Set #1, Line 467: {

    These braces weren't here before

  • Patch Set #1, Line 542: emu_data

    This was named `data` in `dummy_init`, why use a different name for the same thing here?

To view, visit change 45230. To unsubscribe, or for help writing mail filters, visit settings.