Attention is currently required from: Xiang Wang, Stefan Reinauer, Angel Pons.

3 comments:

File bitbang_spi.c:
- Patch Set #12, Line 208:
```
	if (parse_spi_mode(&cpol, &cpha))
		return ERROR_FLASHROM_BUG;
```
  Global static variables are initialized to 0 by default
  No you should initialise to 0 explicitly, not rely on the specific toolchain that happens to be installed.
File bitbang_spi.c:
- Patch Set #14, Line 41:
```
static int cpol; /* Clock Polarity */
static int cpha; /* Clock Phase */
```
  Done
  not done.
- Patch Set #14, Line 210: ERROR_FLASHROM_BUG
  Done
  not done, please don't resolve if not actually resolved.
  You want `SPI_PROGRAMMER_ERROR` here, ERROR_FLASHROM_BUG has a very specific meaning for when things miscompile etc. It's not for here.
  Flashrom has rather poor to non-existent error code sanity, lets not make it any worse here.

To view, visit change 49255. To unsubscribe, or for help writing mail filters, visit settings.