Attention is currently required from: Robert Zieba, Jon Murphy, Edward O'Callaghan, Felix Held.
View Change
1 comment:
Commit Message:
Patch Set #1, Line 11:
Stop using the legacy
spi100 registers and use the correct ones.
I verified that these changes work on Cezanne.
I tried the changes in Dalboz (Picasso SoC) and it is working as expected. I ran the entire suite of flashrom_tester and all of them passed there too.
```
<+> Get_device_name test: Pass
<+> Coreboot_ELOG_sanity test: Pass
<+> Host_is_ChromeOS test: Pass
<+> Toggle_WP test: Pass
<+> Erase_and_Write test: Pass
<+> Fail_to_verify test: Pass
<+> Lock test: Pass
<+> Lock_top_quad test: Pass
<+> Lock_bottom_quad test: Pass
<+> Lock_bottom_half test: Pass
<+> Lock_top_half test: Pass
```
Robert,
Can you please run the flashrom_tester in Cezanne as well?
To view, visit change 63422. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If42130757331f4294b5a42c848557d3287f24fc3
Gerrit-Change-Number: 63422
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Jon Murphy <jpmurphy@google.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: Robert Zieba <robertzieba@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Karthikeyan Ramasubramanian <kramasub@chromium.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Robert Zieba <robertzieba@google.com>
Gerrit-Attention: Jon Murphy <jpmurphy@google.com>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Comment-Date: Thu, 07 Apr 2022 17:26:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Robert Zieba <robertzieba@google.com>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Felix Held <felix-coreboot@felixheld.de>
Gerrit-MessageType: comment