Attention is currently required from: Felix Singer, Michał Żygowski, Paul Menzel, Michael Niewöhner, Sergii Dmytruk.
View Change
1 comment:
File ite_ecfw.c:
Patch Set #29, Line 411: }
Ah, got it. […]
Almost, I guess. We'd still need to split it into the real blocks. What the code
already does. The existing code paths all seem fine, we'd just need to make sure
that ite_ecfw_write() either always gets called for the whole flash at once or
in the correct order. So that in this driver, we always take the same paths, i.e.
write first block minus first 1KiB, write blocks... write last block, write first
1KiB. This needs to stay stable, AIUI.
To view, visit change 55715. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031
Gerrit-Change-Number: 55715
Gerrit-PatchSet: 29
Gerrit-Owner: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Comment-Date: Tue, 08 Mar 2022 22:00:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Michał Żygowski <michal.zygowski@3mdeb.com>
Comment-In-Reply-To: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-MessageType: comment