View Change
1 comment:
File ich_descriptors.c:
Patch Set #5, Line 940: } else if (content->ICCRIBA == 0x34) {
Some feedback from Intel: Based on the PCH EDS 3.0 and the information you provided, the ICCRIBA should be the ICC initialization register ( the ICC stands for Intel Microcode technology).
Due to the different SKUs of PCH parts used on DeltaLake (EVT) and (DVT), the initialization base address of the Microprocessor register is assigned by PCH to different offset address as the 4-KB boundary rules must meet, if the Program Register type. ( section 27.7.1.4.2, page 1914). It turns out that the 0x34 is the value of the Initial Base Address (offset) of the Microprocess register for A1CB QS or PRQ C621A DVT part.
To view, visit change 44621. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I363aaccfb90e0a127c0f0bb0072e9e85c210b669
Gerrit-Change-Number: 44621
Gerrit-PatchSet: 5
Gerrit-Owner: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Bryant Ou <bryant.ou.q@gmail.com>
Gerrit-Reviewer: David Hendricks <dhendrix.sync@gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 01 Sep 2020 17:44:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment