Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Angel Pons.
View Change
1 comment:
Patchset:
Patch Set #4:
Oh, good to know. […]
I wouldn't craft a sanity check through user action (having to specify the I/O port pair) but having a list of supported EC's sounds like a good idea but I wonder if we should check the chip id or better the firmware id (e.g. the "ITE string" or sth else) because support for this firmware-based programming mechanism is implemented in EC fw. The other approach is direct flashing via the flash registers (see it85spi.c, it87spi.c for example), which *should* also work on various ITE ec's even without firmware support.
To view, visit change 55715. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031
Gerrit-Change-Number: 55715
Gerrit-PatchSet: 4
Gerrit-Owner: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Tue, 22 Jun 2021 11:23:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-MessageType: comment