Daniel Campello has uploaded this change for review.
helpers.c: use unsigned it for bit shifts (ASAN)
This change addresses the following ASAN error:
* ASAN error detected:
* ../flashrom-9999/helpers.c:28:13: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'
* #0 0x5589a94bb284 in address_to_bits /build/amd64-generic/tmp/portage/sys-apps/flashrom-9999/work/flashrom-9999-build/../flashrom-9999/helpers.c:28:13
*
* SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../flashrom-9999/helpers.c:28:13 in
BUG=b:224828279
TEST=FEATURES=test emerge-amd64-generic flashrom
BRANCH=none
Signed-off-by: Daniel Campello <campello@chromium.org>
Change-Id: Ib595f13c29dd5c0775e074801756e4f920b4daaf
---
M helpers.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/62/62862/1
diff --git a/helpers.c b/helpers.c
index 289848d..5b47b68 100644
--- a/helpers.c
+++ b/helpers.c
@@ -25,7 +25,7 @@
uint32_t address_to_bits(uint32_t addr)
{
unsigned int lzb = 0;
- while (((1 << (31 - lzb)) & ~addr) != 0)
+ while (((1u << (31 - lzb)) & ~addr) != 0)
lzb++;
return 32 - lzb;
}
To view, visit change 62862. To unsubscribe, or for help writing mail filters, visit settings.