Patch set 10:Code-Review -1

View Change

1 comment:

• File it85spi.c:

  • Patch Set #10, Line 240: struct it85spi_data *data = (struct it85spi_data *) flash->mst->spi.data;

    Take away here is... […]

    I strongly oppose to the use of casts to discard const qualifiers. If the pointer is referencing data marked as const, then modifying data through this pointer will cause undefined behavior.

    I agree that things as-is are pretty messy, but that's the perfect reason to not try to sort this out quickly, and instead re-think the situation thoroughly.

To view, visit change 47655. To unsubscribe, or for help writing mail filters, visit settings.