Attention is currently required from: Anton Samsonov, Peter Marheine, Thomas Heijligen.
Patch set 1:Code-Review +2
View Change
1 comment:
Patchset:
Patch Set #1:
I recalled there was a moment when we tried to upgrade the version but then reverted back. I found the patch CB:73361 but from the comments it seems that 0.56.0 should be fine.
Also indeed substring() was only introduced in 0.56
From Jenkins logs I see that 1.0 is installed on server, so that's even higher.
I hope I am not missing anything?
To view, visit change 77779. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I53c6c42c27a58734742e3dce3cdbde4c65b89a90
Gerrit-Change-Number: 77779
Gerrit-PatchSet: 1
Gerrit-Owner: Anton Samsonov <devel@zxlab.ru>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Anton Samsonov <devel@zxlab.ru>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Thu, 14 Sep 2023 09:20:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment