David Hendricks posted comments on this change.

View Change

Patch set 9:

Let's go with a comment, then. `17-16` still isn't obvious since the reader still needs to look at how it's used in the code and find an older datasheet to infer what is happening.

As an example:
/* HSFC and HSFS 16-bit registers are combined into the 32-bit BIOS_HSFSTS_CTL register in the Sunrise Point datasheet, however we still treat them separately in order to re-use code. */

This also has the advantage of being searchable, in case somebody wants to grep for BIOS_HSFSTS_CTL to see how it's used.

To view, visit change 18962. To unsubscribe, visit settings.