Attention is currently required from: David Hendricks, Angel Pons, Anastasia Klimchuk.
3 comments:
Commit Message:
strdup return values should be checked for NULL to catch the
potential error case of out of memory.
This patch does more than this. It refactors, if you are going to do this I suggest splitting the patch into perhaps two patches.
The first should factor out all this C-typical string parsing hand grenade type stuff into its own static function.
The second patch can refactor the inadequate error handling of ternary operators acting on heap allocating functions. Also if you are going to unroll the ternary operators, do all of them to make the function procedurally obvious.
File layout.c:
Patch Set #5, Line 136: Could not allocate memory
CB:69472
Patch Set #5, Line 149: Could not allocate memory\
CB:69472
To view, visit change 70006. To unsubscribe, or for help writing mail filters, visit settings.