View Change
1 comment:
File edi.c:
Patch Set #3, Line 166: static void edi_draw_attention(struct flashctx *flash)
No, worries. I also thought about inlining it into edi_probe_kb9012(). […]
I've renamed it into edi_draw_attention and also tried to improve the description of this method, hope it is more clear now
To view, visit change 23260. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69ee71674649cd8ba4fc635f889cb39a1cd204b9
Gerrit-Change-Number: 23260
Gerrit-PatchSet: 5
Gerrit-Owner: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Kocialkowski <contact@paulk.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 05 Feb 2018 22:50:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No