Attention is currently required from: Subrata Banik, Edward O'Callaghan, Angel Pons.
2 comments:
Patchset:
Given the subtle differences such as `freq_str` it looks like keeping them separate was the right id […]
Well it's different from EHL, but is it really new? It looks closer to the
big core PCHs, looking at Figure 1 of the datasheet. The masters and regions
in the SPI guide also don't look like what we print for APL/GLK. And from the
CSE version it should be somewhere between Ice Point and Comet Point. I haven't
looked at every single bit, but it seems 300-series compatible (renaming the
enum entry is also an option, if the code matches).
File ich_descriptors.c:
Patch Set #8, Line 1061: CHIPSET_ELKHART_LAKE
I do not but this preserves the current behavior and that sounds like a another patch. […]
EHL has CSSO 0x58. It's in the updated SPI Guide and was confirmed with
a real-world descriptor. IIRC, David wants us to have all paths with
explicit checks plus a fallback default that repeats the most recent
known chipset. That would be a fixup for the ADL/MTL patches, though.
Have a look how things were before your patches and you can get the
idea.
To view, visit change 62282. To unsubscribe, or for help writing mail filters, visit settings.