Attention is currently required from: Nico Huber, David Hendricks, Edward O'Callaghan.
1 comment:
Patchset:
The preprocessor solution to override stdlib functions looks a […]
I spent some time thinking about this. I now have some thoughts about this (first one is critical).
1) There are two different headers for a file under test and for a test (unittest_env.h vs unittest.h). Can this be expressed from the command line: different includes for different files?
2) Using -include directives from the command line means that none of stdlib|unittest|unittest_env headers are included in the file is that correct? So someone looking at the file won't see stdlib included, and only after inspecting Makefile can understand this?
3) Looking from the other side: at the moment there are no inline functions with malloc in flashrom code. Does not seem like a commonly used pattern here? Moving include to a command line seems like a big change, and for all files (not only under /test), I am worried to do this for a problem that does not exist at the moment, and maybe will never exist?
To view, visit change 51243. To unsubscribe, or for help writing mail filters, visit settings.