Attention is currently required from: David Bartley, Nico Huber.
6 comments:
File flashchips.c:
Patch Set #1, Line 17745: W25Q501V
Flash chip entries are sorted alphabetically by vendor and name. This one should be placed between `W25P80` and `W25Q128.V`.
The `5` seems spurious?
Patch Set #1, Line 17757: /* Full chip erase is fastest, typically takes 200s */
Block erasers for the other flash chip entries are intentionally sorted in ascending block size. Please keep this ordering.
# Context
When writing, flashrom first reads the old flash chip contents and only erases/writes the blocks which have changed. This significantly reduces flashing time when only a part of the data needs to be rewritten. This behavior is also useful when using a layout file to only rewrite specific sections of the flash chip.
However, flashrom currently always uses the first block eraser, and only falls back to the other block erasers if there's an error. Dynamically choosing the best block erasers for each case would be great to have, but someone needs to implement it. Patches are welcome!
Patch Set #1, Line 17781: spi_prettyprint_status_register_plain
spi_prettyprint_status_register_bp3_srwd
Patch Set #1, Line 17782: spi_disable_blockprotect
spi_disable_blockprotect_bp3_srwd
nit: use only one blank line (there's two right now)
To view, visit change 54968. To unsubscribe, or for help writing mail filters, visit settings.