Nico Huber posted comments on this change.
View Change
Patch set 7:
(1 comment)
File ichspi.c:
Patch Set #7, Line 49: HSFC_WET_OFF 5
Should be bit 21?
You are off by 16 in both cases ;) the current datasheets treat
HSF STS and CTL as one 32-bit register, where we treat them
separately as HSFS (lower 16 bit) and HSFC (upper 16 bit).
To view, visit change 18962. To unsubscribe, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f4565a3c39f5fe3aec4fc8863605cebed1ad4ee
Gerrit-Change-Number: 18962
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner@gmx.at>
Gerrit-Reviewer: Youness Alaoui <snifikino@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 13 Jul 2017 16:04:52 +0000
Gerrit-HasComments: Yes