View Change
1 comment:
File spi25.c:
Patch Set #6, Line 423: if (status_reg & SPI_SR_ERA_ERR) {
This is a block-protection bit for most chips I've seen.
Upon investigation my dyslexic eye didn't see this the first time around that this block of code comes from `s25f_poll_status():s25f.c` and is not a modification to `spi_poll_wip():spi25.c` in our tree.
Thank you for picking up on this with your sharp eye Nico!
To view, visit change 39822. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If659290874a4b9db6e71256bdef382d31b288e72
Gerrit-Change-Number: 39822
Gerrit-PatchSet: 6
Gerrit-Owner: Samir Ibradžić <sibradzic@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 28 Apr 2020 01:01:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment