Attention is currently required from: Angel Pons, Nikolai Artemiev.
View Change
1 comment:
Patchset:
Patch Set #2:
Did you test if `ich_hwseq_block_erase()` still works? Looking at CB:62869 it did not clear the byte count before.
Seems like the original HW seq refactoring being done by me left few things open (based on the assumption of the EDS default value) and resulted in regression (as mentioned in the commit msg of the CLs https://review.coreboot.org/q/topic:fix_hw_seq_regression).
Kindly help to review those https://review.coreboot.org/q/topic:fix_hw_seq_regression
To view, visit change 69422. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2535bdfb77ff370bddcb507a229bbf4119681cdf
Gerrit-Change-Number: 69422
Gerrit-PatchSet: 2
Gerrit-Owner: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Thu, 17 Nov 2022 15:54:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment