I'm not sure that any of the listed devices are relevant for the description of the functionality of this patch.
Looking at the code in Chromium OS mentioned in the commit message, the while loop only reacts to CDS and then another exit condition is defined through the if upon FCERR.
The flashrom upstream code however alreaady exits the loop on either FCERR or CDS, so the additional if is superfluous, as the exit condition would be reached at the same time as with the patch, just in a tighter loop.
Also, the CDS timeout would be announced through either a an actual timeout or through FCERR aborting the loop. This cosmetic incorrectness is there with and without this patch.
Overall I think the error message should distinguish between those two exit criteria, but (the rest of) this patch should be abandoned.
Patch set 1:Code-Review -1
To view, visit change 46325. To unsubscribe, or for help writing mail filters, visit settings.