Nico Huber submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved
nicintel: remove unused rget_io_perms()

The nicintel programmer does not use x86 IO Ports. Remove the dependency
to it.

Change-Id: Ibe609ff8f8fdbdf2a7de8e1922325ca4ad56a9e7
Signed-off-by: Thomas Heijligen <thomas.heijligen@secunet.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/60844
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M Makefile
M nicintel.c
2 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/Makefile b/Makefile
index 7859362..da38d6b 100644
--- a/Makefile
+++ b/Makefile
@@ -128,7 +128,6 @@
CONFIG_ATAPROMISE \
CONFIG_INTERNAL \
CONFIG_NIC3COM \
- CONFIG_NICINTEL \
CONFIG_NICINTEL_EEPROM \
CONFIG_NICINTEL_SPI \
CONFIG_NICNATSEMI \
diff --git a/nicintel.c b/nicintel.c
index 21dfad2..c8a8789 100644
--- a/nicintel.c
+++ b/nicintel.c
@@ -19,7 +19,6 @@
#include "flash.h"
#include "programmer.h"
#include "hwaccess.h"
-#include "hwaccess_x86_io.h"
#include "hwaccess_physmap.h"
#include "platform/pci.h"

@@ -71,12 +70,6 @@
struct pci_dev *dev = NULL;
uintptr_t addr;

- /* Needed only for PCI accesses on some platforms.
- * FIXME: Refactor that into get_mem_perms/rget_io_perms/get_pci_perms?
- */
- if (rget_io_perms())
- return 1;
-
/* FIXME: BAR2 is not available if the device uses the CardBus function. */
dev = pcidev_init(nics_intel, PCI_BASE_ADDRESS_2);
if (!dev)

To view, visit change 60844. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ibe609ff8f8fdbdf2a7de8e1922325ca4ad56a9e7
Gerrit-Change-Number: 60844
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged