Looks good, but the output should be more user friendly.

View Change

2 comments:

• File cli_classic.c:

  • Patch Set #1, Line 386: logfile[0] != '\0'

    nit, just `if (logfile)` would be enough. It was initialized to `NULL` above,
    `if (logfile)` would tell us if that changed already.

  • Patch Set #1, Line 387: Warning: log file not free of older string. Running free() rightnow.\n

    Well, if we follow the code flow, it's clear that this happens (only) when
    there were multiple `-o <logfile>` on the command line (you can try btw.).
    So we should state that here (a user wouldn't understand what free() means).
    e.g.

        "Warning: -o/--output specified multiple times.\n"

To view, visit change 34405. To unsubscribe, or for help writing mail filters, visit settings.