Attention is currently required from: Nico Huber, Edward O'Callaghan.

View Change

3 comments:

• File dummyflasher.c:

  • Patch Set #1, Line 716: return 1;

    Doesn't `data` leak here as well? And also in the other return paths.

    Yes it does. I think dummy needs refactoring of init, to allocate data at the very end of init (instead of the very beginning) and also to make sure all init failure paths do cleanup.
    I am doing this gradually for the tree, it's just dummy's turn hasn't come yet!

  • Patch Set #1, Line 982: free(status);

    For another patch: this is the same story as CB:46551

    Thanks for the link, I will definitely look at this.

  • Patch Set #1, Line 986: return 1;

    `flashchip_contents` also leaks here. We could also move this check to run before the malloc() call. […]

    Yes, malloc should be at the end I think.
    I would [ideally] submit this one first, if possible, so that I won't need to merge with myself.

To view, visit change 52557. To unsubscribe, or for help writing mail filters, visit settings.