Attention is currently required from: Nikolai Artemiev, Sergii Dmytruk.

Patch set 5:Code-Review -1

View Change

1 comment:

• File spi25_statusreg.c:

  • Patch Set #5, Line 33:

    	if ((flash->mst->buses_supported & BUS_PROG) && flash->mst->opaque.write_register) {
    		return flash->mst->opaque.write_register(flash, reg, value);
    	}
    

    I am inclined to move this specalisation to actually within writeprotect.c I feel this layer violates as-is and that flashrom probably should be refactored some to wrap up the spi command issuing semantics and master selection behind some kind of internal API.

To view, visit change 64375. To unsubscribe, or for help writing mail filters, visit settings.