Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk.
Patch set 13:Code-Review +1
View Change
1 comment:
Patchset:
Patch Set #13:
I think you can remove [RFC][WPTST] at this stage :) I am talking about 5 patches, dummy+tests (keep it for OTP for now).
First prefix [RFC] is not needed anymore, this is already well into review.
Speaking about [WPTST], if it has some meaning and you want to keep the meaning, you can express that as topic for patches. You can later search by topic (for example https://review.coreboot.org/q/topic:unit_tests). Topic is entirely optional, up to you. I usually set topic for my patches, but otherwise not many people use it.
How to set the topic: p.5 in here https://www.flashrom.org/Development_Guidelines#Push_your_patch
To view, visit change 59071. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iccb69a8d3a0dd2192e2c938caddaf07b1889ed35
Gerrit-Change-Number: 59071
Gerrit-PatchSet: 13
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Comment-Date: Wed, 15 Dec 2021 02:03:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment