Attention is currently required from: Anastasia Klimchuk, Peter Marheine.
View Change
1 comment:
File meson.build:
Patch Set #2, Line 133: if host_machine.system() in ['cygwin', 'windows']
Would it be reasonable to put this Windows detection in platform/ too? Or is OS detection a differen […]
Yes, we can move it here first. This is one of the symbols I want to get rid off and split the code into a windows and non windows file inside the platform dir.
To view, visit change 63826. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I88044a3f903f316138483dd872a6d95f8686ae69
Gerrit-Change-Number: 63826
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Tue, 26 Apr 2022 06:56:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org>
Gerrit-MessageType: comment