Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.
5 comments:
File tests/init_shutdown.c:
this number is very arbitrary. Something that is obvious like -1 or 0x55AA [01010101 10101010] is better.
why not just `/` is something special happening here?
Patch Set #4, Line 230: num_bytes = 0;
seems like a bug? strings in C are null terminated which is a byte.
Patch Set #4, Line 274: Provide pagesize into buf.
It is better to describe where the value is from and why it has it the particular value than re-describing what the code already shows.
`/* Fix pagesize to 1MB. */`
seems to be wht you are doing here?
Patch Set #4, Line 275: memcpy(buf, "1048576", len);
just, `return memcpy(buf, "1048576", len);` memcpy returns the ptr to dest (buf in this case).
To view, visit change 56413. To unsubscribe, or for help writing mail filters, visit settings.