Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Peter Marheine.
1 comment:
File ichspi.c:
static bool ich_spi_probe_opcode(const struct flashctx *flash, uint8_t opcode)
{
return find_opcode(curopcodes, opcode) >= 0;
That way, ich_spi_send_command will automatically reprogram the required opcode if it is missing and we don't have to restore JEDEC_SE after every command that reprograms it.
I have once considered this, but the issue is that spi_master_ich7 does use ich_spi_send_(multi)command() but does not implement .probe_opcode().
Bill, would you agree to change your patch, and test the different solution?
As a plan B I can upload new version of the patch, but asking you first because you are the author (and you did all the debugging).
Also, in any case, original author of the patch stays (even if someone uploads new version)
If you have a better solution, you are free to replace mine.
To view, visit change 84253. To unsubscribe, or for help writing mail filters, visit settings.