Attention is currently required from: Aarya, Anastasia Klimchuk, Nikolai Artemiev.
View Change
1 comment:
File erasure_layout.c:
Patch Set #1, Line 263:
old_start_buf = (uint8_t *)malloc(old_start - region_start);
if (!old_start_buf) {
msg_cerr("Not enough memory!\n");
ret = -1;
goto _end;
}
old_end_buf = (uint8_t *)malloc(region_end - old_end);
if (!old_end_buf) {
msg_cerr("Not enough memory!\n");
ret = -1;
goto _end;
}
Oh I think this piece is also somewhat relevant to the patch. […]
Thanks for the details, Anastasia! Yeah, I will dive deeper to see possible solutions and understand code better. I have a few thoughts on how to rewrite it, but I need to test them.
To view, visit change 81548. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I99aad4119f9c11bea75e3419926cc833bc1f68c5
Gerrit-Change-Number: 81548
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@chromium.org>
Gerrit-Attention: Aarya <aarya.chaumal@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Wed, 03 Apr 2024 16:07:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment