Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
6 comments:
File doc/release_notes/v_1_4.rst:
Patch Set #1, Line 5: Release notes for flashrom version 1.4.0.
It seems nice to include a little intro paragraph here, acknowledging contributors and providing a little bit of context.
This document describes the major changes in flashrom version 1.4.0, from 438 patches contributed by 73 authors in the 6 months since version 1.3.0.
(I used `git shortlog -s -n v1.3.0..v1.4.0-rc1` to count authors, and `git log --oneline v1.3.0..v1.4.0-rc1` to count commits.)
Patch Set #1, Line 10: Fix AMD programmer (sb600spi.c) for Promontory and chips >16MB size
I see this is the title of the issue, but starting a known issue with "Fix" seems confusing.
Probably this should be phrased more like:
AMD-based PCs with FCH are unable to read flash contents for internal (BIOS flash) chips larger than 16 MB, and attempting to do so may crash the system. Systems with AMD "Promontory" IO extenders (mostly "Zen" desktop platforms) are not currently supported.
* Calibration loop is not used anymore, except for DOS
* Removed unconditional 1 second delay for SPI chips
* Lower the sleep vs delay threshold to 0.1 seconds
* Tree-wide refactorings around programmer_delay and internal_delay
This is technically all true, but I think it should be rearranged to highlight the parts that users might need to be aware of.
```suggestion
* Flashrom now sleeps more aggressively when a delay is required, rather than
polling in a loop. This should reduce power consumption significantly, but
may require more time to complete operations on systems experiencing high
CPU load.
* An unconditional 1-second delay was removed for SPI flashes. This is not
believed to be needed for any SPI flashes, but may be needed for some old
parallel flashes (where it remains in used).
* Cycle-counting busy loops are now only used on DOS builds of flashrom. All
other platforms use OS timers for timed delays, which are expected to be
more accurate.
* Tree-wide refactorings around programmer_delay and internal_delay
```
Patch Set #1, Line 38: Note: the migration process is half way.
Should this mention that the wiki is deprecated and will go away eventually, but information from the wiki is being migrated?
Our current two build systems, meson and make, are on par
---------------------------------------------------------
Both build systems support the same platforms and both are documented (however, unit tests only supported with meson).
**This is the last release with two build systems. With the next release, make and Makefile will no longer be supported, and we will have one build system: meson.**
As with the delay section, I think this should highlight things that might affect users (or in this case, distributors).
```suggestion
Makefile scheduled for removal
------------------------------
**Future versions of flashrom will drop support for building via Makefile**: Meson will become the only supported build system.
The Makefile and meson build systems are currently at feature parity, except automated testing is supported only with meson. To reduce the maintenance burden, we plan to remove the Makefile after this release.
```
Patch Set #1, Line 292: Download
I think this should be at the top, right after the intro paragraph.
To view, visit change 83359. To unsubscribe, or for help writing mail filters, visit settings.