Attention is currently required from: Alexandru Stan, Nikolai Artemiev, Stefan Reinauer.
Patch set 3:Code-Review +2
View Change
1 comment:
File flashchips.c:
Patch Set #2, Line 20269:
.printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD,
.unlock = SPI_DISABLE_BLOCKPROTECT,
Sorry Nikolai. I'm not an expert at WPing and I very rarely even connect my programmer to a chip. […]
I think it's fine to add without WP support, especially if you haven't used or tested it.
Nikolai, I hope it's fine for you? Maybe someone (who would be using WP) will add support later.
To view, visit change 84752. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ibf670e4014a22e4636789768b759cb51f75cd046
Gerrit-Change-Number: 84752
Gerrit-PatchSet: 3
Gerrit-Owner: Alexandru Stan <ams@frame.work>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Alexandru Stan <ams@frame.work>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Wed, 06 Nov 2024 06:09:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Alexandru Stan <ams@frame.work>
Comment-In-Reply-To: Nikolai Artemiev <nartemiev@google.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>