Attention is currently required from: Nico Huber, Thomas Heijligen.

Patch set 2:Code-Review +1

8 comments:

Commit Message:
- Patch Set #2, Line 7: descriptor
  nit: missing plural `s` in `descriptors`
- Patch Set #2, Line 9: remove
  use gerund form: `removing`
- Patch Set #2, Line 12: descriptor
  nit: missing plural `s` in `descriptors`
- Patch Set #2, Line 13: Makefie
  typo: missing `l` in `Makefile`
- Patch Set #2, Line 16: set CFLAGS and EXEC_SUFFIX for TARGET_OS not for the HOST_OS
  Two nits:
```
 - Drop `the` in `for the HOST_OS` for consistency with `for TARGET_OS`
 - Add a comma after `TARGET_OS`
```
```
 set CFLAGS and EXEC_SUFFIX for TARGET_OS, not for HOST_OS
```
- Patch Set #2, Line 19: descriptor
  nit: missing plural `s` in `descriptors`
- Patch Set #2, Line 18:
```
Don't pass the EXEC_SUFFIX from the main Makefile to
ich_descriptor_tool/Makefile.
```
  I see that `TARGET_OS` is no longer passed either. I imagine it wasn't mentioned in the commit message because `util/ich_descriptors_tool/Makefile` overrides it anyway.
  Still, I'd mention `TARGET_OS` in the commit message.
File util/ich_descriptors_tool/Makefile:
- Patch Set #2, Line 42: */
  nit: remove?

To view, visit change 58468. To unsubscribe, or for help writing mail filters, visit settings.