Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• File stlinkv3_spi.c:

  • Patch Set #1, Line 533: stlinkv3_spi_open(sck_freq_kHz, stlinkv3_handle

    >>> Before this commit, the handle was closed unless register_shutdown() failed. […]

    It's just the one more `goto err_exit` that you added (in case calloc
    fails). It's one more case where resources are left open than before.
    It's tiny compared to the other flaws around. So don't worry too much
    about it.

    I just realized there's even a double-libusb_exit() in case register_
    spi_master() fails... and a new double-free() in this patch. So yes,
    I think it's probably best to fix the error paths first. This change
    would be easier to review if the code was sane already. I can also
    fix things, it's more my fault that the code looks like this ;)

To view, visit change 54042. To unsubscribe, or for help writing mail filters, visit settings.