Patch Set 1:
> (7 comments)
Thank you very much for the review Nico!
Actually tgotic proposed a much simpler (and I think better)
approach for checking the MingW environment:
https://github.com/flashrom/flashrom/pull/33
Is it possible to upload a new patchset if I am not an owner at
the
gerrit?Hi Márton,
Did you plan to upload a revision to address Nico's comments? It
would be great to get this merged soon and reduce the patch queue.
I have not been able to find where can I update my patchset.
Could you please upload this as a new version of the patchset: https://patch-diff.githubusercontent.com/raw/flashrom/flashrom/pull/33.diff
I have simplified the check to make it not depending on bash neither using regexps so it should address Nico comments.
1 comment:
Patch Set #1, Line 104: ifeq ($(shell if [[ $$(uname) =~ ^MINGW[0-9]{0,2}_NT-[0-9]{1,2}.[0-9]{1,2}$$ ]]; then echo yes; else echo no; fi), yes)
I'm not familiar with the syntax. […]
Well kind of. It is a regular expression, inspiration came from here:
https://stackoverflow.com/questions/31111360/how-to-use-regular-expression-in-makefile-if-statement
If you have any recommendation how to make a better conditional check based on a regexp please let me know.
To view, visit change 23865. To unsubscribe, or for help writing mail filters, visit settings.