Attention is currently required from: Nico Huber, Edward O'Callaghan, Nikolai Artemiev.

View Change

1 comment:

• Commit Message:

  • Patch Set #3, Line 13:

    and paves way
    to remove the 'programmer' global handle.
    

    Because 42 programmers had to dispatch `internal_delay()` via deference though `programmer->delay()` […]

    Hmmmmm, I'm not sure if I understand you, probably because I'm not awake enough yet. Even if 42 programmers use `internal_delay()`, you still need to account for the two programmers (ch341a_spi, serprog) using a different function. So, unless you need to change things regarding `struct programmer_entry` to get rid of the `programmer` global handle, this change shouldn't make the removal easier.

    TL;DR: I'm OK with this change, I just don't understand how it would have an effect on the removal of the `programmer` global handle.

To view, visit change 67391. To unsubscribe, or for help writing mail filters, visit settings.