Attention is currently required from: Nico Huber, Paul Menzel.

View Change

2 comments:

• File chipset_enable.c:

  • Patch Set #3, Line 659: { "eSPI", BUS_LPC | BUS_FWH } };

    I would simply put `{ "eSPI", 0 }` here. "eSPI" is what the datasheet […]

    Done. Although used BUS_NONE instead of zero

• File flash.h:

  • Patch Set #10, Line 71: BUS_NONSPI = BUS_PARALLEL | BUS_LPC | BUS_FWH,

    This would definitely need an update. Although, I'm not sure if it is […]

    Hard to tell. BUS_NONSPI is mostly used on older southbridges/chipsets in chipset_enable. Also there is a comment (over 5 years old) in flashrom.c:

    	/*
    	 * FIXME: Once all chipsets and flash chips have been updated, NONSPI
    	 * will cease to exist and should be eliminated here as well.
    	 */

    which suggest there should be some cleanup.

To view, visit change 55578. To unsubscribe, or for help writing mail filters, visit settings.