Attention is currently required from: Thomas Heijligen, Angel Pons, Steve Markgraf.
2 comments:
Patchset:
Hello Steve,
Thank you so much for your contribution!
While this will need to go through all reviews from other people as well, I have a question to you. As you are an original author of the programmer, would you agree to add yourself into MAINTAINERS file for this programmer? This would mean you will be automatically added as reviewer if someone sends a patch which touches code for the programmer. Also since MAINTAINERS file is a bit of documentation, you will be the person who "knows something about this programmer" and people might ask you questions :) It would be great if you agree!
As I said, the patch needs to go through all reviews, but I decided to ask a question now so you can think about it. Thank you!
File linux_gpiod.c:
if (data) {
if (gpiod_line_bulk_num_lines(&data->bulk) > 0)
gpiod_line_release_bulk(&data->bulk);
free(data);
}
if (chip)
gpiod_chip_close(chip);
I have few questions about the error path exit.
1) It looks like it is doing the same as shutdown function (which of course makes sense). Is it possible to try re-write a bit, so that just call shutdown function? If any changes are needed later for shutdown process, only one place would need to be changed.
2) The first two callsites of `goto err_exit` , where there is no data and chip is not opened yet: does anything need to be done there? could that be `return 1` (tell me if I am wrong)? I am thinking that maybe those two first callsites could be `return 1` and then err_exit could just call shutdown function?
To view, visit change 71801. To unsubscribe, or for help writing mail filters, visit settings.