Edward O'Callaghan submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Sam McNally: Looks good to me, approved
raiden_debug_spi.c: Allow custom_rst param value of 'false'

As identified while documenting driver, allow for passing
'false' even though it is the default for custom_rst to be
consistent.

BUG=b:224358254
TEST=builds

Change-Id: I25bfe6f8e3f7cfffb1a9c99ac90ec56a750d7f84
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/63601
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sam McNally <sammc@google.com>
---
M raiden_debug_spi.c
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/raiden_debug_spi.c b/raiden_debug_spi.c
index 3f35552..65ce32b 100644
--- a/raiden_debug_spi.c
+++ b/raiden_debug_spi.c
@@ -1412,9 +1412,11 @@
int ap_request = RAIDEN_DEBUG_SPI_REQ_ENABLE_AP;
char *custom_rst_str = extract_programmer_param("custom_rst");
if (custom_rst_str) {
- if (!strcasecmp(custom_rst_str, "true"))
+ if (!strcasecmp(custom_rst_str, "true")) {
ap_request = RAIDEN_DEBUG_SPI_REQ_ENABLE_AP_CUSTOM;
- else {
+ } else if (!strcasecmp(custom_rst_str, "false")) {
+ ap_request = RAIDEN_DEBUG_SPI_REQ_ENABLE_AP;
+ } else {
msg_perr("Invalid custom rst param: %s\n",
custom_rst_str);
ap_request = -1;

To view, visit change 63601. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I25bfe6f8e3f7cfffb1a9c99ac90ec56a750d7f84
Gerrit-Change-Number: 63601
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged